Update PULL_REQUEST_TEMPLATE to include an API spec change in the checklist. #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cklist. Signed-off-by: dblock <dblock@amazon.com>
dblock
requested review from
lezzago,
AWSHurneyt,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
bowenlan-amzn,
rishabhmaurya,
engechas,
riysaxen-amzn and
jowg-amazon
as code owners
22 tasks
|
@AWSHurneyt @sbcd90 anyone? |
|
Taking a look. |
AWSHurneyt
approved these changes
Aug 12, 2024
engechas
approved these changes
Aug 12, 2024
|
Lots of approvals, can a maintainer hit merge please? |
bowenlan-amzn
approved these changes
Aug 14, 2024
bowenlan-amzn
merged commit 9cc29bb
into
opensearch-project:main
13 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from opensearch-project/opensearch-api-specification#387, update PR template to include a checkbox that requests that all API changes be documented in the OpenAPI spec used to generate clients.