Remove user from the responses #201
Conversation
| Assert.assertTrue(alerts.single().errorMessage?.contains("The destination address is invalid") as Boolean) | ||
| Assert.assertNotNull(alerts.single().errorMessage) |
There was a problem hiding this comment.
Why is this check being modified? It doesn't seem like the error message should have changed.
There was a problem hiding this comment.
This is one of the flaky test, not really part of user object changes. I have this test failing sometimes when security is enabled.
There was a problem hiding this comment.
Ah ok that makes sense. Thanks.
There was a problem hiding this comment.
If this fails sometimes but your assertNotNull check doesn't, it means that there is an error message but not the one we expect. That would mean the Alert is failing for another reason. Did you get a chance to see what the error was in these scenarios?
There was a problem hiding this comment.
@skkosuri-amzn By the way, I realized even as far back as our plugin version being 1.0.0, the Pull and Run Docker step in our Multi-node test workflow has been failing with Error response from daemon: manifest for opensearchstaging/opensearch:<version> not found: manifest unknown: manifest unknown. Is that a known issue?
There was a problem hiding this comment.
@skkosuri-amzn By the way, I realized even as far back as our plugin version being
1.0.0, the Pull and Run Docker step in our Multi-node test workflow has been failing withError response from daemon: manifest for opensearchstaging/opensearch:<version> not found: manifest unknown: manifest unknown. Is that a known issue?
I am not aware of that. Looks like its a different one based on above error msg.
Issue #, if available:
Remove user from the responses
Description of changes:
Remove user from the responses
All unit and integ passed. All security tests also passed.
./gradlew :alerting:integTest -Dtests.rest.cluster=localhost:9200 -Dtests.cluster=localhost:9200 -Dtests.clustername=opensearch -Dhttps=true -Dsecurity=true -Duser=admin -Dpassword=adminCheckList:
[x] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.