Draft for intergration test of CRUD APIs and validation #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jiahe zhang <zhanncha@amazon.com>
lezzago
requested changes
Mar 9, 2022
alerting/src/test/kotlin/org/opensearch/alerting/resthandler/MonitorRestApilTForDocument.kt
Show resolved
Hide resolved
alerting/src/test/kotlin/org/opensearch/alerting/resthandler/MonitorRestApilTForDocument.kt
Show resolved
Hide resolved
alerting/src/test/kotlin/org/opensearch/alerting/resthandler/MonitorRestApilTForDocument.kt
Show resolved
Hide resolved
|
Create tests where creating an incorrect monitor fails. For example, creating document level monitor with query level trigger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jiahe zhang zhanncha@amazon.com
Issue #, if available:
Description of changes:
For the Create/Update APIs, ensure there is validation to ensure the monitor is defined correctly. Also in general for the APIs, ensure there no issues when executing the CRUD APIs on doc level monitor and the other monitor types based on the changes
CheckList:
[ ] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.