Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build qualifier default to alpha1 for 2.0.0 #373

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu zhujiaxi@amazon.com

Issue #, if available:
#348

Description of changes:
Add build qualifier default to alpha1 for 2.0.0

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2022

Codecov Report

Merging #373 (5f07d0e) into main (5a1b96f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #373   +/-   ##
=========================================
  Coverage     79.00%   79.00%           
  Complexity      268      268           
=========================================
  Files           176      176           
  Lines          7286     7286           
  Branches       1016     1016           
=========================================
  Hits           5756     5756           
+ Misses         1004     1003    -1     
- Partials        526      527    +1     
Impacted Files Coverage Δ
...ain/kotlin/org/opensearch/alerting/AlertService.kt 78.92% <0.00%> (-0.50%) ⬇️
...ing/model/destination/DestinationContextFactory.kt 78.57% <0.00%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a1b96f...5f07d0e. Read the comment docs.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Copy link
Member Author

Please keep this PR open for now.

@peterzhuamazon peterzhuamazon merged commit c0698ca into opensearch-project:main Mar 31, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-2.0.0-qualifier-2 branch March 31, 2022 17:12
Angie-Zhang pushed a commit to Angie-Zhang/alerting that referenced this pull request Jun 29, 2022
* Add build qualifier default to alpha1 for 2.0.0

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Update workflows

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Angie Zhang <langelzh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants