[Extensions] Migrates Delete Detector Results #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## feature/extensions #881 +/- ##
========================================================
+ Coverage 34.94% 34.96% +0.02%
+ Complexity 1895 1888 -7
========================================================
Files 300 300
Lines 17915 17856 -59
Branches 1869 1862 -7
========================================================
- Hits 6261 6244 -17
+ Misses 11201 11164 -37
+ Partials 453 448 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joshpalis
approved these changes
Apr 28, 2023
src/main/java/org/opensearch/ad/rest/RestDeleteAnomalyResultsAction.java
Show resolved
Hide resolved
vibrantvarun
reviewed
May 1, 2023
src/main/java/org/opensearch/ad/rest/RestDeleteAnomalyResultsAction.java
Outdated
Show resolved
Hide resolved
vibrantvarun
reviewed
May 1, 2023
src/main/java/org/opensearch/ad/transport/DeleteAnomalyResultsTransportAction.java
Outdated
Show resolved
Hide resolved
vibrantvarun
reviewed
May 1, 2023
src/main/java/org/opensearch/ad/transport/DeleteAnomalyResultsTransportAction.java
Outdated
Show resolved
Hide resolved
owaiskazi19
force-pushed
the
delete-detector-results
branch
from
6f6ac55 to
0ff87e8
Compare
dbwiddis
requested changes
May 1, 2023
src/main/java/org/opensearch/ad/rest/RestDeleteAnomalyResultsAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/ad/rest/RestDeleteAnomalyResultsAction.java
Show resolved
Hide resolved
src/main/java/org/opensearch/ad/rest/RestDeleteAnomalyResultsAction.java
Show resolved
Hide resolved
src/test/java/org/opensearch/ad/transport/DeleteAnomalyResultsTransportActionTests.java
Show resolved
Hide resolved
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
owaiskazi19
force-pushed
the
delete-detector-results
branch
from
0ff87e8 to
aeba9fa
Compare
dbwiddis
approved these changes
May 2, 2023
src/main/java/org/opensearch/ad/rest/RestDeleteAnomalyResultsAction.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: opensearch-project/opensearch-sdk-java#713 needs to be merged for build to pass.
This PR migrates Delete Detector Results to extension for DELETE request.
Issues Resolved
Fixes opensearch-project/opensearch-sdk-java#378
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.