Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move linux-build off container, onto ubuntu-latest runner #673

Closed

Conversation

finnegancarroll
Copy link
Collaborator

@finnegancarroll finnegancarroll commented Nov 13, 2024

Description

Prepping ci for #666.
The main blocker for bumping all github actions past v3 is illustrated by this comment:

# actions/checkout@v4 and actions/setup-java@v4 use node 20:
# https://github.com/actions/checkout/releases/tag/v4.0.0
# container image does not have GLIBC_2.28 required for this node version
# as such use @v3 actions instead for this workflow and set ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION

As such, this dependency on the opensearch-build docker container is problematic. Taking a look at the security plugin it seems like they forgo the opensearch-build container and run natively on linux-build instead. I cannot think of a reason why we can't do the same and am unsure why the linux build needs to be run on a docker container in the first place.

This pr moves the linux-build stage off this docker container.

Related Issues

#666
Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
@cwperks
Copy link
Member

cwperks commented Nov 14, 2024

IMO The CI checks should use the container provided by the build team. The checks intentionally run on that image.

@peterzhuamazon and @prudhvigodithi have been exploring a solution to this issue in opensearch-project/job-scheduler#702 and opensearch-project/job-scheduler#700

Find more details about the use of this runner in the original PR: #507

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Nov 14, 2024

IMO The CI checks should use the container provided by the build team. The checks intentionally run on that image.

@peterzhuamazon and @prudhvigodithi have been exploring a solution to this issue in opensearch-project/job-scheduler#702 and opensearch-project/job-scheduler#700

Find more details about the use of this runner in the original PR: #507

I am very close to fix this now, you can wait for a bit and I would be able to provide a solution soon.
We should not move out of the AL2 docker image as that is the exact same one we use for production build on Jenkins.

Thanks.

@finnegancarroll
Copy link
Collaborator Author

Got it. Closing this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants