Changed bucket name to env variable #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshien
requested review from
getsaurabh02,
peterzhuamazon,
gaiksaya,
prudhvigodithi and
nhtruong
as code owners
bshien
force-pushed
the
change-event-bucket-name
branch
from
f94058e
to
54f6049
Compare
src/call/github-events-to-s3.ts
Outdated
| @@ -26,7 +26,7 @@ export default async function githubEventsToS3(app: Probot, context: any, resour | |||
| try { | |||
| const s3Client = new S3Client({ region: String(process.env.REGION) }); | |||
| const putObjectCommand = new PutObjectCommand({ | |||
| Bucket: 'opensearch-project-github-events', | |||
| Bucket: String(process.env.BUCKET_NAME), | |||
There was a problem hiding this comment.
Just change this to OPENSEARCH_EVENTS_BUCKET, so that we can accommodate different buckets for future use cases.
bshien
force-pushed
the
change-event-bucket-name
branch
2 times, most recently
from
db7c713
to
6d5377d
Compare
prudhvigodithi
approved these changes
Oct 9, 2024
prudhvigodithi
approved these changes
Oct 9, 2024
Signed-off-by: Brandon Shien <bshien@amazon.com>
bshien
force-pushed
the
change-event-bucket-name
branch
from
6d5377d
to
83dd26f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed bucket name to env variable to allow the user to chose which s3 bucket to upload events to.
Issues Resolved
opensearch-project/opensearch-metrics#85
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.