-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Version to Monitor Github workflows using the automation app #4
Conversation
d662051
to
e58bb05
Compare
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
bcda74b
to
947196e
Compare
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
I think all of this needs tests at a minimum. There's no way we're going to have an app where thousands of lines of code gets deployed across all repos without some assurance that they will actually work. |
I agree with you @dblock, I'm waiting for Peter to define a test workflow in this repo, we should add tests and proper code coverage before we switch to public. |
Yes DB, I totally agree we need test here. Thanks. |
c6876f3
to
e8288db
Compare
e8288db
to
d9012c1
Compare
Added few tests for |
eee0d73
to
79e91a5
Compare
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
79e91a5
to
b7d4959
Compare
Thanks @prudhvigodithi we will be following instructions here: Some examples you can check here: I will do some research and make tweaks based on your changes as well. |
5787a30
to
b6c0abb
Compare
Thanks @peterzhuamazon will take a look at your comments, for now added |
3f3ab8b
to
8180ca9
Compare
8180ca9
to
ec5317b
Compare
@peterzhuamazon addressed your comments and updated the |
ec5317b
to
13a8700
Compare
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
13a8700
to
9c9aa84
Compare
Added two new tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Initial Version to Monitor Github workflows:
pull_request.closed
andworkflow_run.completed
events.github-merged-pulls-monitor
andgithub-workflow-runs-monitor
to parse the events and index to the metrics cluster.OpensearchClient
to useAwsSigv4Signer
and connect to the metrics cluster.OperationConfig
to support the newconfigSchema
forargs
..licenserc.json
.OpensearchClient
andgithub-merged-pulls-monitor
andgithub-workflow-runs-monitor
.build.yml
tobuild-test.yml
to include some testing during the PR creation.Issues Resolved
Part of opensearch-project/opensearch-build#4941 (comment)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.