Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added params to Datasources #290

Merged

Conversation

petardz
Copy link
Contributor

@petardz petardz commented Oct 19, 2022

Signed-off-by: Petar petar.dzepina@gmail.com

Description

Added history index params to DataSources model

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Petar <petar.dzepina@gmail.com>
@petardz petardz requested a review from a team October 19, 2022 21:52
Signed-off-by: Petar <petar.dzepina@gmail.com>
Signed-off-by: Petar <petar.dzepina@gmail.com>
eirsep
eirsep previously approved these changes Oct 19, 2022
Signed-off-by: Petar <petar.dzepina@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #290 (b0181b1) into main (c231644) will increase coverage by 0.16%.
The diff coverage is 88.67%.

@@             Coverage Diff              @@
##               main     #290      +/-   ##
============================================
+ Coverage     71.52%   71.68%   +0.16%     
- Complexity      666      667       +1     
============================================
  Files           108      108              
  Lines          4477     4514      +37     
  Branches        605      605              
============================================
+ Hits           3202     3236      +34     
- Misses         1024     1027       +3     
  Partials        251      251              
Impacted Files Coverage Δ
...ain/java/org/opensearch/commons/authuser/User.java 87.82% <ø> (ø)
...commons/destination/message/LegacyBaseMessage.java 67.44% <ø> (ø)
...estination/message/LegacyCustomWebhookMessage.java 74.68% <ø> (ø)
...ensearch/commons/rest/SecureRestClientBuilder.java 52.33% <75.00%> (+1.85%) ⬆️
...g/opensearch/commons/alerting/model/DataSources.kt 69.41% <87.50%> (+7.11%) ⬆️
...search/commons/alerting/action/GetAlertsRequest.kt 97.14% <100.00%> (+0.47%) ⬆️
...arch/commons/alerting/model/ClusterMetricsInput.kt 80.00% <100.00%> (+0.51%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eirsep eirsep merged commit b9f370f into opensearch-project:main Oct 19, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 19, 2022
Signed-off-by: Petar <petar.dzepina@gmail.com>
(cherry picked from commit b9f370f)
eirsep pushed a commit that referenced this pull request Oct 20, 2022
Signed-off-by: Petar <petar.dzepina@gmail.com>
(cherry picked from commit b9f370f)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
wuychn pushed a commit to ochprince/common-utils that referenced this pull request Mar 16, 2023
…ect#291)

Signed-off-by: Petar <petar.dzepina@gmail.com>
(cherry picked from commit b9f370f)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
AWSHurneyt pushed a commit to AWSHurneyt/common-utils that referenced this pull request Apr 12, 2024
…ect#291)

Signed-off-by: Petar <petar.dzepina@gmail.com>
(cherry picked from commit b9f370f)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants