-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added params to Datasources #290
Merged
eirsep
merged 4 commits into
opensearch-project:main
from
petardz:alertFindingHistoryInDatasource
Oct 19, 2022
Merged
added params to Datasources #290
eirsep
merged 4 commits into
opensearch-project:main
from
petardz:alertFindingHistoryInDatasource
Oct 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petar <petar.dzepina@gmail.com>
Signed-off-by: Petar <petar.dzepina@gmail.com>
Signed-off-by: Petar <petar.dzepina@gmail.com>
eirsep
previously approved these changes
Oct 19, 2022
Codecov Report
@@ Coverage Diff @@
## main #290 +/- ##
============================================
+ Coverage 71.52% 71.68% +0.16%
- Complexity 666 667 +1
============================================
Files 108 108
Lines 4477 4514 +37
Branches 605 605
============================================
+ Hits 3202 3236 +34
- Misses 1024 1027 +3
Partials 251 251
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
eirsep
approved these changes
Oct 19, 2022
sbcd90
approved these changes
Oct 19, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 19, 2022
Signed-off-by: Petar <petar.dzepina@gmail.com> (cherry picked from commit b9f370f)
eirsep
pushed a commit
that referenced
this pull request
Oct 20, 2022
5 tasks
AWSHurneyt
pushed a commit
to AWSHurneyt/common-utils
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Petar petar.dzepina@gmail.com
Description
Added history index params to DataSources model
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.