fix findings parsing logic introduced by pr #292 #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eirsep
previously approved these changes
Oct 20, 2022
|
Will this cause backward compatibility issues in response structure as this would be released in minor version hence asking |
lezzago
previously approved these changes
Oct 20, 2022
eirsep
dismissed
their stale review
Discussed with @sbcd90 for a holistic fix
Codecov Report
@@ Coverage Diff @@
## main #294 +/- ##
============================================
+ Coverage 71.81% 73.16% +1.35%
- Complexity 683 696 +13
============================================
Files 110 110
Lines 4569 4573 +4
Branches 604 606 +2
============================================
+ Hits 3281 3346 +65
+ Misses 1037 976 -61
Partials 251 251
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
eirsep
approved these changes
Oct 21, 2022
|
Thanks for fixing issue and adding the tests @sbcd90 ! |
lezzago
approved these changes
Oct 21, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 21, 2022
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> (cherry picked from commit b737142)
eirsep
pushed a commit
that referenced
this pull request
Oct 21, 2022
wuychn
pushed a commit
to ochprince/common-utils
that referenced
this pull request
Mar 16, 2023
… (opensearch-project#295) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> (cherry picked from commit b737142) Co-authored-by: Subhobrata Dey <sbcd90@gmail.com>
AWSHurneyt
pushed a commit
to AWSHurneyt/common-utils
that referenced
this pull request
Apr 12, 2024
… (opensearch-project#295) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> (cherry picked from commit b737142) Co-authored-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Subhobrata Dey sbcd90@gmail.com
Description
fix findings parsing logic introduced by pr #292
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.