Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.4 release notes #316

Merged
merged 2 commits into from
Nov 4, 2022
Merged

2.4 release notes #316

merged 2 commits into from
Nov 4, 2022

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Nov 4, 2022

Signed-off-by: Surya Sashank Nistala snistala@amazon.com

Issues Resolved

#280

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@eirsep eirsep requested a review from a team November 4, 2022 22:57
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

Merging #316 (fac28a9) into main (b7ceeec) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #316      +/-   ##
============================================
+ Coverage     73.40%   73.42%   +0.01%     
  Complexity      698      698              
============================================
  Files           110      110              
  Lines          4580     4587       +7     
  Branches        605      606       +1     
============================================
+ Hits           3362     3368       +6     
  Misses          968      968              
- Partials        250      251       +1     
Impacted Files Coverage Δ
...n/org/opensearch/commons/alerting/model/Monitor.kt 81.67% <0.00%> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

* Copy over monitor datasources config from alerting to common utils ([#247](https://github.com/opensearch-project/common-utils/pull/247))
* expose delete monitor api from alerting ([#251](https://github.com/opensearch-project/common-utils/pull/251))
* Move Findings and Alerts action, request, response and models from alerting to common-utils ([#254](https://github.com/opensearch-project/common-utils/pull/254))
* * move acknowledge alerts dtos from alerting to common-utils ([#283](https://github.com/opensearch-project/common-utils/pull/282))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Remove the extra *

* Support backend roles in indexMonitorRequest ([#308](https://github.com/opensearch-project/common-utils/pull/308))
* Added function for request recreation that considers the writeable request ([#303](https://github.com/opensearch-project/common-utils/pull/303))
* Adds owner field in monitor model ([#313](https://github.com/opensearch-project/common-utils/pull/313))

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Remove the extra new line

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
@eirsep eirsep merged commit 5fd25b0 into opensearch-project:main Nov 4, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 5, 2022
* 2.4 release notes

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* minor fixes

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
(cherry picked from commit 5fd25b0)
eirsep added a commit that referenced this pull request Nov 5, 2022
* 2.4 release notes

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* minor fixes

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
(cherry picked from commit 5fd25b0)

Co-authored-by: Surya Sashank Nistala <sashank.nistala@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants