Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix streaming functions for LegacySNSMessage #324

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

lezzago
Copy link
Member

@lezzago lezzago commented Nov 22, 2022

Signed-off-by: Ashish Agrawal ashisagr@amazon.com

Description

Fix streaming functions for LegacySNSMessage

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022

Codecov Report

Merging #324 (3e7b3c3) into main (050c95d) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #324      +/-   ##
============================================
+ Coverage     73.29%   73.31%   +0.01%     
  Complexity      696      696              
============================================
  Files           110      110              
  Lines          4595     4594       -1     
  Branches        606      606              
============================================
  Hits           3368     3368              
+ Misses          976      975       -1     
  Partials        251      251              
Impacted Files Coverage Δ
.../commons/destination/message/LegacySNSMessage.java 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lezzago lezzago merged commit 84b4ee3 into opensearch-project:main Nov 23, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 23, 2022
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 84b4ee3)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 23, 2022
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 84b4ee3)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 23, 2022
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 84b4ee3)
lezzago added a commit that referenced this pull request Jan 24, 2023
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 84b4ee3)

Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
lezzago added a commit that referenced this pull request Jan 24, 2023
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 84b4ee3)

Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
lezzago added a commit that referenced this pull request Jan 24, 2023
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 84b4ee3)

Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 24, 2023
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 84b4ee3)
eirsep pushed a commit that referenced this pull request Feb 1, 2023
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 84b4ee3)

Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
wuychn pushed a commit to ochprince/common-utils that referenced this pull request Mar 16, 2023
…opensearch-project#325)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 84b4ee3)

Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
AWSHurneyt pushed a commit to AWSHurneyt/common-utils that referenced this pull request Apr 12, 2024
…opensearch-project#325)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 84b4ee3)

Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants