Fix SNS regex for validation on notification channel to support SNS FIFO topics. #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
lezzago
approved these changes
Mar 15, 2023
sbcd90
approved these changes
Mar 15, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 15, 2023
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit deed4bd)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 15, 2023
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit deed4bd)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 15, 2023
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit deed4bd)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 15, 2023
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit deed4bd)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 15, 2023
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit deed4bd)
eirsep
added a commit
that referenced
this pull request
Mar 15, 2023
eirsep
added a commit
that referenced
this pull request
Mar 15, 2023
eirsep
added a commit
that referenced
this pull request
Mar 15, 2023
eirsep
added a commit
that referenced
this pull request
Mar 15, 2023
eirsep
added a commit
that referenced
this pull request
Mar 15, 2023
AWSHurneyt
pushed a commit
to AWSHurneyt/common-utils
that referenced
this pull request
Apr 12, 2024
…rch-project#381) (opensearch-project#383) Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit deed4bd) Co-authored-by: Surya Sashank Nistala <sashank.nistala@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed SNS regex for validation on notification channel to support SNS FIFO topics.
SNS FIFO topic ARN regex validation was throwing error
java.lang.IllegalArgumentException: Invalid AWS SNS topic ARN: arn:aws:sns:ap-southeast-2:33365477133:sns-fifo-alerting.fifoIssues Resolved
#382
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.