Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Generic error for persistent task on starting replication #1002

Closed
wants to merge 5 commits into from
Closed

Conversation

nisgoel-amazon
Copy link
Contributor

Description

This change will fix the generic error coming in case of replication failed in restore phase.
This change will also return the acknowledgement as 200 when replication failed in restore phase and put the failed reason in metadata store, which can be view via replication status API

Issues Resolved

#707

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #1002 (a67ab40) into main (59b5543) will decrease coverage by 0.32%.
The diff coverage is 54.90%.

❗ Current head a67ab40 differs from pull request most recent head 78f6c24. Consider uploading reports for the commit 78f6c24 to get more accurate results

@@             Coverage Diff              @@
##               main    #1002      +/-   ##
============================================
- Coverage     73.22%   72.91%   -0.32%     
- Complexity     1010     1018       +8     
============================================
  Files           141      141              
  Lines          4699     4740      +41     
  Branches        527      536       +9     
============================================
+ Hits           3441     3456      +15     
- Misses          933      949      +16     
- Partials        325      335      +10     
Impacted Files Coverage Δ
...rch/replication/task/index/IndexReplicationTask.kt 68.13% <25.00%> (+0.41%) ⬆️
...action/stop/TransportStopIndexReplicationAction.kt 56.12% <36.84%> (-4.64%) ⬇️
...TransportReplicateIndexClusterManagerNodeAction.kt 91.66% <50.00%> (-1.56%) ⬇️
...ication/seqno/RemoteClusterRetentionLeaseHelper.kt 70.43% <69.56%> (+7.16%) ⬆️
...on/repository/RemoteClusterRestoreLeaderService.kt 78.37% <100.00%> (ø)
...rch/replication/task/shard/ShardReplicationTask.kt 76.81% <100.00%> (+0.89%) ⬆️

... and 2 files with indirect coverage changes

nisgoel-amazon and others added 5 commits June 20, 2023 08:06
…tore state

Signed-off-by: Nishant Goel <nisgoel@amazon.com>
Signed-off-by: Ankit Kala <ankikala@amazon.com>
Clear stale replication tasks in STOP API

Signed-off-by: monusingh-1 <msnghgw@amazon.com>
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants