Move version out of gradle.properties and resolve dynamically. #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dblock <dblock@dblock.org>
dblock
requested review from
CEHENKLE,
peternied,
ankitkala and
saikaranam-amazon
This was referenced Dec 18, 2021
dblock
requested review from
amkhar,
gbbafna,
krishna-ggk,
naveenpajjuri,
rohin,
rushiagr,
shahzer12,
soosinha,
tbhanu-amzn and
varunsrivathsav
Signed-off-by: dblock <dblock@dblock.org>
peternied
approved these changes
Dec 18, 2021
ankitkala
approved these changes
Dec 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dblock dblock@dblock.org
Description
The version in gradle.properties is 1.2.2, but OpenSearch is 1.2.3, so the built plugin has no chance of working. This change prevents a conflict between the version in gradle.properties and the OpenSearch version passed in, as most plugins do.
I also opened #274, does the security plugin snapshot need to be updated?
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.