Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added basic sanity tests for single cluster scenario. #393

Merged

Conversation

naveenpajjuri
Copy link
Contributor

@naveenpajjuri naveenpajjuri commented May 6, 2022

Signed-off-by: Naveen Pajjuri nppajjur@amazon.com

Description

Currently OS distribution doesn't support tests with multiple cluster. Cross cluster replication requires more than 1 cluster to run even basic integ tests.
Till OS build team comes up with support for multiple cluster's we are having couple of tests which just checks ccr plugin installation and trigger basic api's like start/stop and validate the expected error response.

Issues Resolved

(#383)

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@naveenpajjuri naveenpajjuri requested a review from a team May 6, 2022 09:36
@naveenpajjuri naveenpajjuri marked this pull request as draft May 6, 2022 09:52
Signed-off-by: Naveen Pajjuri <nppajjur@amazon.com>
@naveenpajjuri naveenpajjuri force-pushed the singleClusterSanityTests branch from d2ad8e7 to 38f185e Compare May 6, 2022 10:50
@naveenpajjuri naveenpajjuri marked this pull request as ready for review May 6, 2022 11:11
@@ -858,3 +859,27 @@ task "bwcTestSuite"(type: RestIntegTestTask) {
dependsOn tasks.named("rollingUpgradeClusterTask")
dependsOn tasks.named("fullRestartClusterTask")
}

task integTestSingleCluster(type: RestIntegTestTask) {
useCluster testClusters.singleCluster
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use the remote cluster provided by the opensearch distro build.

@ankitkala
Copy link
Member

Merging this change for now. Incase there are any comments, i'll take those up in a follow up PR.

Copy link
Member

@saikaranam-amazon saikaranam-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets follow-up with the changes for remote cluster support

@ankitkala ankitkala merged commit 9c4f7e2 into opensearch-project:main May 9, 2022
@opensearch-trigger-bot
Copy link

The backport to 1.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.2 1.2
# Navigate to the new working tree
cd .worktrees/backport-1.2
# Create a new branch
git switch --create backport/backport-393-to-1.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9c4f7e2124035ef4a382ba7d00ccc9e7e36f56d0
# Push it to GitHub
git push --set-upstream origin backport/backport-393-to-1.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.2

Then, create a pull request where the base branch is 1.2 and the compare/head branch is backport/backport-393-to-1.2.

ankitkala added a commit that referenced this pull request May 17, 2022
* added basic sanity tests for single cluster scenario. (#393)

Signed-off-by: Ankit Kala <ankikala@amazon.com>

* Add support to run sanity test on remote cluster (#394)

Signed-off-by: Ankit Kala <ankikala@amazon.com>

Co-authored-by: naveenpajjuri <naveenpajjuri93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants