Hide notebook feature when MDS enabled and remove security dashboard API dependency calling #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
raintygao
changed the title
raintygao
requested review from
lezzago,
joshuali925,
anirudha,
ruanyl,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am and
wanglam
as code owners
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
SuZhou-Joe
reviewed
Jun 5, 2024
| /** | ||
| * Returns true if current user has permission to use assistant features. | ||
| */ | ||
| userHasAccess: () => Promise<boolean>; |
There was a problem hiding this comment.
Is it safe to remove this API?
There was a problem hiding this comment.
In my understanding, we use this property to control user access to assistant. If we remove security API and don't control user access in frontend, we could remove this API, right?
SuZhou-Joe
approved these changes
Jun 5, 2024
wanglam
reviewed
Jun 5, 2024
wanglam
reviewed
Jun 5, 2024
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
wanglam
approved these changes
Jun 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
…API dependency calling (#201) * hide notebook feature when mds enabled Signed-off-by: tygao <tygao@amazon.com> * remove useraccess Signed-off-by: tygao <tygao@amazon.com> * add internal account api Signed-off-by: tygao <tygao@amazon.com> * test: update tests Signed-off-by: tygao <tygao@amazon.com> * doc: update changelog Signed-off-by: tygao <tygao@amazon.com> * update mock function Signed-off-by: tygao <tygao@amazon.com> * update mock function Signed-off-by: tygao <tygao@amazon.com> * delete unused file Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com> (cherry picked from commit e834cd5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
raintygao
pushed a commit
that referenced
this pull request
Jun 6, 2024
…API dependency calling (#201) (#202) * hide notebook feature when mds enabled Signed-off-by: tygao <tygao@amazon.com> * remove useraccess Signed-off-by: tygao <tygao@amazon.com> * add internal account api Signed-off-by: tygao <tygao@amazon.com> * test: update tests Signed-off-by: tygao <tygao@amazon.com> * doc: update changelog Signed-off-by: tygao <tygao@amazon.com> * update mock function Signed-off-by: tygao <tygao@amazon.com> * update mock function Signed-off-by: tygao <tygao@amazon.com> * delete unused file Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com> (cherry picked from commit e834cd5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hide notebook feature when MDS enabled and remove security dashboard API dependency calling
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.