filter preset and enrich data section processors based on version #522
Conversation
and change enrich data section processors based on the version. Add processor list change is out of scope of this CR. Signed-off-by: Kama Huang <kamahuan@amazon.com>
kamahuan
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz,
jackiehanyang,
minalsha and
saimedhi
as code owners
| // Current processors state | ||
| const [processors, setProcessors] = useState<IProcessorConfig[]>([]); | ||
|
|
||
| useEffect(() => { | ||
| if (props.uiConfig && props.context) { |
There was a problem hiding this comment.
The processors state here represents the individual workflow config's configured processors, not the list of available processors, so we shouldn't change this existing logic or this custom hook.
In general, I don't disagree with the filtering logic, but it should live somewhere else. Note the context menu on lines 247-324 is where the available processors list exists; here is where we should have the determined final list of processors based on the version shown.
There was a problem hiding this comment.
Hey Tyler, the filtering logic is updated in my second PR. Can we resolve every other comments in the PR and then proceed to the second PR to fix this?
There was a problem hiding this comment.
The processor filtering should only be needed in this component, and not in the other enrich data sections. I believe most of the second PR won't be needed once the changes are made in this one.
There was a problem hiding this comment.
related to previous comments, but we shouldn't need any such idea of a filtered count. The components can just display what exists in the workflow's ui config as before.
Signed-off-by: Kama Huang kamahuan@amazon.com
Description
Use datasource to get backend version.
If open search backend version is 2.17.0:
if open search backend version is 2.19.0:
Upon checking this PR only handle version before 2.17.0 and 2.19.0. 2.18.0 is not handled.
Add processor list change is out of scope of this CR.
Issues Resolved
NONE
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.