Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(OUI Next Theme) Maps #448

Closed
4 tasks done
Tracked by #895
KrooshalUX opened this issue Jul 25, 2023 · 5 comments
Closed
4 tasks done
Tracked by #895

(OUI Next Theme) Maps #448

KrooshalUX opened this issue Jul 25, 2023 · 5 comments
Assignees
Labels
v2.10.0 Issues targeting release v2.10.0

Comments

@KrooshalUX
Copy link

KrooshalUX commented Jul 25, 2023

This issue to be transferred to corresponding repository

I am working on launching new light and dark mode themes provided by OUI component library for a target launch within 2.10. These changes support the vision expressed in Future Vision for Dashboards

I have identified the following front end related issues that prevent the theme from appearing complete and potential solutions within this feature:

Screen Shot 2023-07-25 at 4 06 12 PM
  • Draw rectangle button icon is set to primary, but should be set to ghost which will adjust appropriately between dark & light modes
  • Draw polygon icon is set to inherit color, therefore is showing too dark in dark mode, should be set to ghost which will adjust appropriately between dark & light modes
  • While in dark mode, Zoom controls showing in light mode
  • While in dark mode, map tiles showing in light mode
@wbeckler wbeckler transferred this issue from opensearch-project/oui Jul 27, 2023
@vamshin vamshin added the v2.10.0 Issues targeting release v2.10.0 label Aug 8, 2023
@junqiu-lei
Copy link
Member

There are some open source styles from https://openmaptiles.org/styles, and we can also generate our own map style by https://openmaptiles.org/docs/style/maputnik/. @KrooshalUX we might need your help to choose the dark style we are going to use for base tile maps. Thanks!

@KrooshalUX
Copy link
Author

Thanks @junqiu-lei - I have taken a look at the styles, and based on our previous conversation we are limited to the GL styles.

The dark tiles provided in the GL styles "Dark Matter" https://openmaptiles.org/styles/#dark-matter is too low contrast however.

Is it possible to translate the style from "Dark" https://openmaptiles.org/styles/#dark - which is not available in GL- into a custom map style using Maputnik as mentioned above? This one is much more legible and provides better contrast between water, land and boundaries.

@junqiu-lei
Copy link
Member

junqiu-lei commented Aug 9, 2023

Hi @KrooshalUX, we need to use the GL styles for our vector tile service, we can make some adjust based on the "Dark Matter" style on the open source tool https://maputnik.github.io/editor and get the output style json file.

In the maputnik page, you can click the "Open" and select "Dark Matter" or other style as base style and then edit.

Here is one example I just made a little change on the water color from "Dark Matter".

image

@KrooshalUX
Copy link
Author

KrooshalUX commented Aug 16, 2023

@junqiu-lei to keep you un-blocked for this release, lets go with this change to Dark Matter for now. My recommendation is that we work together on a color palette for map tiles that is higher contrast in the next release. cc @mnkugler @nandi-github

@junqiu-lei
Copy link
Member

junqiu-lei commented Aug 18, 2023

#455 merged, we can create a issue to track the higher contrast dark style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.10.0 Issues targeting release v2.10.0
Projects
None yet
Development

No branches or pull requests

3 participants