Support dark mode in maps-dashboards #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junqiu-lei
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda and
martin-gaievski
as code owners
Codecov Report
@@ Coverage Diff @@
## main #455 +/- ##
==========================================
- Coverage 41.40% 41.36% -0.05%
==========================================
Files 53 53
Lines 1775 1789 +14
Branches 326 328 +2
==========================================
+ Hits 735 740 +5
- Misses 1012 1019 +7
- Partials 28 30 +2 |
VijayanB
reviewed
Aug 17, 2023
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
VijayanB
approved these changes
Aug 18, 2023
|
Cypress tests passed at local, the Github cypress CI failure is unrelated to this PR. |
martin-gaievski
approved these changes
Aug 18, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 18, 2023
Signed-off-by: Junqiu Lei <junqiu@amazon.com> (cherry picked from commit 5344f27)
junqiu-lei
added a commit
that referenced
this pull request
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support dark mode in maps-dashboards:
opensearchVectorTileStyleUrlto be a style manifest which can contain multiple styles from server.Issues Resolved
#448
Demo
Screen.Recording.2023-08-15.at.11.55.18.PM.mov
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.