Add rectangle as custom mode #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
force-pushed
the
add-rectangle-mode
branch
from
bc04699
to
38334db
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #247 +/- ##
=======================================
Coverage 85.00% 85.00%
=======================================
Files 14 14
Lines 400 400
Branches 57 57
=======================================
Hits 340 340
Misses 43 43
Partials 17 17 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
VijayanB
force-pushed
the
add-rectangle-mode
branch
from
38334db
to
91fb79a
Compare
VijayanB
force-pushed
the
add-rectangle-mode
branch
2 times, most recently
from
f60372b
to
aff81a7
Compare
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
force-pushed
the
add-rectangle-mode
branch
from
aff81a7
to
83aeed2
Compare
New draw mode that extends polygon but behaves like rectangle. On First click, coordinate is set. On Second click the rectangle is created as bounding box. This will be used for drawing bounding box. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
force-pushed
the
add-rectangle-mode
branch
from
83aeed2
to
1583f81
Compare
junqiu-lei
approved these changes
Mar 8, 2023
heemin32
approved these changes
Mar 8, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 23, 2023
* Add dependency to mapbox-gl-draw * Add rectangle mode New draw mode that extends polygon but behaves like rectangle. On First click, coordinate is set. On Second click the rectangle is created as bounding box. This will be used for drawing bounding box. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> (cherry picked from commit 7a53e13)
VijayanB
pushed a commit
that referenced
this pull request
Mar 23, 2023
* Add dependency to mapbox-gl-draw * Add rectangle mode New draw mode that extends polygon but behaves like rectangle. On First click, coordinate is set. On Second click the rectangle is created as bounding box. This will be used for drawing bounding box. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mapbox-gl-draw doesn't support rectangle natively, but supports an option to add custom mode.
This PR will create new custom mode using types available for extension. This is typescript version of same
mode that is available in geojson.io.
Issues Resolved
#213
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.