Add shape filter UI button #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will contain properties that are common to all layers. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
force-pushed
the
add-shape-filter-ui-button
branch
from
f5be7cc to
03f6003
Compare
junqiu-lei
reviewed
Mar 7, 2023
| }; | ||
|
|
||
| return ( | ||
| <EuiPanel style={{ maxWidth: 300, border: 'hidden' }}> |
There was a problem hiding this comment.
Shall we move the style to css file?
common/index.ts
Outdated
Comment on lines
151
to
154
| export enum FILTER_DRAW_MODE { | ||
| NONE = 'none', | ||
| POLYGON = 'polygon', | ||
| } |
There was a problem hiding this comment.
Could you provide some words on what's the NONE and POLYGON mean?
This will add polygon button which provides context menu to select parameters like relation, label. Add cancel button if it starts drawing. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
force-pushed
the
add-shape-filter-ui-button
branch
from
03f6003 to
19860e6
Compare
junqiu-lei
reviewed
Mar 8, 2023
Comment on lines
+151
to
+160
| export enum FILTER_DRAW_MODE { | ||
| NONE = 'none', // draw filter is inactive | ||
| POLYGON = 'polygon', // Filter is active and set to draw polygon | ||
| } | ||
|
|
||
| export interface DrawFilterProperties { | ||
| relation?: string; | ||
| mode: FILTER_DRAW_MODE; | ||
| filterLabel?: string; | ||
| } |
There was a problem hiding this comment.
How about introduce a prop isDrawActive, the mode only contains different type of draw.
enum FILTER_DRAW_MODE {
POLYGON = 'polygon', // Filter is active and set to draw polygon
CIRCLE='circle',
}
export interface DrawFilterProperties {
relation?: string;
isDrawActive: boolean
mode: FILTER_DRAW_MODE;
filterLabel?: string;
}
There was a problem hiding this comment.
Good suggestion. Then we have to maintain two variable for 1 behavior. For ex: if draw is false, then i have to reset mode to null, similarly if we want to enable draw behavior, we have to set to true and set mode accordingly.
junqiu-lei
approved these changes
Mar 8, 2023
martin-gaievski
approved these changes
Mar 8, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 8, 2023
* Add spatial filter toolbar This will add polygon button which provides context menu to select parameters like relation, label. Add cancel button if it starts drawing. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> (cherry picked from commit 9fffd01)
VijayanB
pushed a commit
that referenced
this pull request
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add spatial filter toolbar with polygon button. This will just accept input and save it in map container.
Later DrawFilter Component will render draw polygon feature.
Issues Resolved
#213
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Screen.Recording.2023-03-07.at.2.48.42.PM.mov