Add mapbox-gl draw mode #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if tooltip state is draw , mount mapbox-gl-draw and change mode accordingly. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
force-pushed
the
add-mapbox-gl-draw
branch
from
9b494ce
to
b01eb6d
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #347 +/- ##
==========================================
- Coverage 85.71% 84.42% -1.29%
==========================================
Files 18 18
Lines 448 456 +8
Branches 66 71 +5
==========================================
+ Hits 384 385 +1
- Misses 43 49 +6
- Partials 21 22 +1 see 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
junqiu-lei
reviewed
Mar 15, 2023
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
junqiu-lei
approved these changes
Mar 15, 2023
martin-gaievski
approved these changes
Mar 15, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 15, 2023
* Add mapbox-gl draw mode if tooltip state is draw , mount mapbox-gl-draw and change mode accordingly. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> (cherry picked from commit 4f108ec)
VijayanB
pushed a commit
that referenced
this pull request
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
if tooltip state is draw , mount mapbox-gl-draw and change mode accordingly.
Added callback once draw is completed. Currently, callback will reset the draw mode. In future PR, will
add Filter Meta based on draw shape.
Issues Resolved
#213
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Screen.Recording.2023-03-14.at.5.45.44.PM.mov