-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed maps tooltip display at dark mode #564
Conversation
5574a16
to
3458e55
Compare
I still see a white triangle at the bottom of the tooltip in darkmode. (just a minor nitpick) |
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
3458e55
to
51c8a67
Compare
@kgcreative Thanks, updated this part |
LGTM! |
(cherry picked from commit 843c1fc)
We may have to see how this popover is implemented. Is it hard coded or using the popover component? Works for now but the border does not appear to be merged with and applied to the popover arrow indicator:
VS --- Also, this issue is not just in Dark mode as stated in here: |
Yeah, my understanding is we're "sort of" making it look like OUI, but there will be differences. |
Description
Followed from #458 (comment), this PR:
Test
Before:

After:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.