Replaced wrongly formatted mock Slack URLs with properly formatted mock Slack URLs #139
Conversation
…mmy Slack URL Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu>
Noir01
requested review from
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
zhichao-aws,
yuye-aws,
getsaurabh02,
sbcd90 and
praveensameneni
as code owners
|
I don't understand why these tests are failing. |
will fix the failing by #140 |
Got it. |
|
How can I trigger the checks again? I think they might've been failing cause the tests in main weren't updated. Now that #814 has been merged, I think the tests will pass. |
Rerunning now |
Ran `yar test:jest -u` Signed-off-by: Aniruddh <ansriv2005@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
=======================================
Coverage 86.70% 86.70%
=======================================
Files 52 52
Lines 1497 1497
Branches 360 360
=======================================
Hits 1298 1298
Misses 196 196
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Sorry, I don't understand the error messages again. I'm not very familiar with Cypress, so I'm not able to debug either. |
Should be a flaky test, rerunning it to see the result. |
…ck Slack URLs (#139) * Replaced wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> * Update snapshot of unit tests Ran `yar test:jest -u` Signed-off-by: Aniruddh <ansriv2005@gmail.com> --------- Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit 7aba242) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ck Slack URLs (#139) (#143) * Replaced wrongly formatted dummy Slack URL with properly formatted dummy Slack URL * Update snapshot of unit tests Ran `yar test:jest -u` --------- (cherry picked from commit 7aba242) Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Hailong Cui <ihailong@amazon.com>
Integrates with #814 in the backend notifications repo
Description
Replaces mock Slack URLs (which wouldn't pass validation tests) with mock Slack URLs (which will pass validation tests)
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.