[Fit & Finish] Updated Fit and Finish guidelines #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldong51
requested review from
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
zhichao-aws,
yuye-aws,
getsaurabh02,
sbcd90,
praveensameneni,
amsiglan,
AWSHurneyt and
riysaxen-amzn
as code owners
Signed-off-by: Dan Dong <danieldong51@gmail.com>
danieldong51
force-pushed
the
fit_and_finish
branch
from
5666496 to
857755a
Compare
Signed-off-by: Dan Dong <danieldong51@gmail.com>
danieldong51
force-pushed
the
fit_and_finish
branch
from
857755a to
ef8156a
Compare
zhongnansu
reviewed
Sep 5, 2024
fixed! |
zhongnansu
approved these changes
Sep 6, 2024
Hailong-am
approved these changes
Sep 6, 2024
riysaxen-amzn
approved these changes
Sep 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Updated Fit and Finish guidelines Signed-off-by: Dan Dong <danieldong51@gmail.com> * Updated Snapshot Tests Signed-off-by: Dan Dong <danieldong51@gmail.com> --------- Signed-off-by: Dan Dong <danieldong51@gmail.com> (cherry picked from commit 68316a0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Updated Fit and Finish guidelines Signed-off-by: Dan Dong <danieldong51@gmail.com> * Updated Snapshot Tests Signed-off-by: Dan Dong <danieldong51@gmail.com> --------- Signed-off-by: Dan Dong <danieldong51@gmail.com> (cherry picked from commit 68316a0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Sep 17, 2024
* Updated Fit and Finish guidelines * Updated Snapshot Tests --------- (cherry picked from commit 68316a0) Signed-off-by: Dan Dong <danieldong51@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Sep 17, 2024
* Updated Fit and Finish guidelines * Updated Snapshot Tests --------- (cherry picked from commit 68316a0) Signed-off-by: Dan Dong <danieldong51@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jowg-amazon
added a commit
to jowg-amazon/dashboards-notifications
that referenced
this pull request
Sep 24, 2024
jowg-amazon
added a commit
to jowg-amazon/dashboards-notifications
that referenced
this pull request
Sep 24, 2024
…project#256) (opensearch-project#259)" This reverts commit fb48dbc. Signed-off-by: Joanne Wang <jowg@amazon.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Sep 24, 2024
* Revert "[Backport 2.17] Fit and Finish UX Fixes Pt 2. (#275)" This reverts commit 5ac0919. Signed-off-by: Joanne Wang <jowg@amazon.com> * Revert "Fit and Finish UX Fixes (#263) (#269)" This reverts commit b3dd31c. Signed-off-by: Joanne Wang <jowg@amazon.com> * Revert "Use TopNavControlButtonData for channel test button (#243) (#268)" This reverts commit 127eae4. Signed-off-by: Joanne Wang <jowg@amazon.com> * Revert "[Fit & Finish] Updated Fit and Finish guidelines (#256) (#259)" This reverts commit fb48dbc. Signed-off-by: Joanne Wang <jowg@amazon.com> --------- Signed-off-by: Joanne Wang <jowg@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the following Fit and Finish guidelines for Notifications Repo:
a. H1: For page header (handled centrally) or page titles without a page header (these shouldn’t exist)
b. H2: For headings immediately under H1s, Modal and Flyout titles, top level Panel titles
c. H3: For headings immediately below H2s
Screenshots
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.