Removes Zeppelin code and docs #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
requested review from
pjfitzgibbons,
ps48,
kavithacm,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
|
@ps48 is zeppelin still being used? If not I would be happy to change this to a PR of removal of zeppelin code and docs |
YANG-DB
approved these changes
Dec 13, 2023
2 tasks
Swiddis
reviewed
Dec 26, 2023
| @@ -75,7 +75,7 @@ | |||
|
|
|||
| - Change transport.type to http | |||
| - host → localhost (if running on same machine as Zeppelin) & port → 9200 | |||
| - username: admin & password: admin | |||
| - username: `admin` & password: `<admin password>` | |||
There was a problem hiding this comment.
If we're not going to provide specific values it can be better to not use a placeholder with brackets. Maybe "Use the username admin and the configured password (default admin)".
Signed-off-by: Derek Ho <dxho@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1296 +/- ##
==========================================
- Coverage 51.57% 51.32% -0.25%
==========================================
Files 305 303 -2
Lines 10651 10584 -67
Branches 2793 2778 -15
==========================================
- Hits 5493 5432 -61
+ Misses 5112 5106 -6
Partials 46 46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Swiddis
approved these changes
Dec 27, 2023
ps48
reviewed
Jan 5, 2024
common/constants/notebooks.ts
Outdated
| @@ -4,7 +4,7 @@ | |||
| */ | |||
|
|
|||
| export const NOTEBOOKS_API_PREFIX = '/api/observability/notebooks'; | |||
| export const NOTEBOOKS_SELECTED_BACKEND: 'ZEPPELIN' | 'DEFAULT' = 'DEFAULT'; | |||
| export const NOTEBOOKS_SELECTED_BACKEND = 'DEFAULT'; | |||
There was a problem hiding this comment.
Can remove this constant if not used anywhere.
ps48
requested changes
Jan 5, 2024
There was a problem hiding this comment.
@derek-ho we have some more files related to Zeppelin you may want to remove before merging this PR:
server/adaptors/notebooks/zeppelin_backend.tspublic/components/notebooks/components/helpers/zeppelin_parser.tsxserver/adaptors/notebooks/index.tspublic/components/notebooks/components/helpers/__tests__/sampleZeppelinNotebooks.tsx
Also, it would be great to link the previously created issue for removing Zeppelin in description.
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
…vability into admin
Signed-off-by: Derek Ho <dxho@amazon.com>
ps48
approved these changes
Jan 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 5, 2024
* Update admin:admin reference Signed-off-by: Derek Ho <dxho@amazon.com> * Remove zeppelin code and docs Signed-off-by: Derek Ho <dxho@amazon.com> * Remove unecessary files Signed-off-by: Derek Ho <dxho@amazon.com> * Remove unnecessary constant Signed-off-by: Derek Ho <dxho@amazon.com> * Remove file Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit c241368) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Jan 5, 2024
* Update admin:admin reference * Remove zeppelin code and docs * Remove unecessary files * Remove unnecessary constant * Remove file --------- (cherry picked from commit c241368) Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 tasks
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…project#1340) * Update admin:admin reference * Remove zeppelin code and docs * Remove unecessary files * Remove unnecessary constant * Remove file --------- (cherry picked from commit c241368) Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 0b42c04)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes Zeppelin code and docs
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.