Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress enhancement and fixes for log explorer #1347

Conversation

mengweieric
Copy link
Collaborator

@mengweieric mengweieric commented Jan 9, 2024

Description

  • fix query manager issue for resolving test error
  • fix tests

Issues Resolved

#1338

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mengweieric mengweieric force-pushed the enhancement/cypress-log-explorer branch 2 times, most recently from 83a93b5 to 3de49a7 Compare January 9, 2024 19:07
@mengweieric mengweieric force-pushed the enhancement/cypress-log-explorer branch from e380d49 to 732e486 Compare January 17, 2024 00:59
@mengweieric mengweieric marked this pull request as ready for review January 17, 2024 01:00
@mengweieric mengweieric added the enhancement New feature or request label Jan 17, 2024
@mengweieric mengweieric changed the title Enhancement/cypress log explorer Cypress enhancement and fixes for log explorer Jan 18, 2024
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
@mengweieric mengweieric force-pushed the enhancement/cypress-log-explorer branch from 732e486 to 5d07555 Compare February 1, 2024 21:42
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (eb1440e) 54.66% compared to head (4a31909) 54.65%.

Files Patch % Lines
...mon/query_manager/query_parser/ppl_query_parser.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1347      +/-   ##
==========================================
- Coverage   54.66%   54.65%   -0.02%     
==========================================
  Files         317      317              
  Lines       11361    11362       +1     
  Branches     3027     3027              
==========================================
- Hits         6211     6210       -1     
- Misses       5099     5101       +2     
  Partials       51       51              
Flag Coverage Δ
dashboards-observability 54.65% <60.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mengweieric mengweieric deleted the enhancement/cypress-log-explorer branch February 14, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants