Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.12] [BUG] Fix Panels PPL Filter #1419

Merged
merged 1 commit into from
Feb 6, 2024
Merged

[Backport 2.12] [BUG] Fix Panels PPL Filter #1419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...omponents/custom_panels/panel_modules/visualization_container/visualization_container.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
onRefresh: boolean;
pplFilterValue: string;
usedInNotebooks?: boolean;
onEditClick: (savedVisualizationId: string) => any;

Check warning on line 78 in public/components/custom_panels/panel_modules/visualization_container/visualization_container.tsx

View workflow job for this annotation

GitHub Actions / Lint 

Unexpected any. Specify a different type
cloneVisualization?: (visualzationTitle: string, savedVisualizationId: string) => void;
showFlyout?: (isReplacement?: boolean | undefined, replaceVizId?: string | undefined) => void;
removeVisualization?: (visualizationId: string) => void;
Expand Down Expand Up @@ -274,7 +274,7 @@
savedVisualizationId,
startTime: fromTime,
endTime: toTime,
pplFilterValue,
filterQuery: pplFilterValue,
span,
resolution,
setVisualizationTitle,
Expand Down Expand Up @@ -316,12 +316,12 @@
)}
</div>
),
[onRefresh, isLoading, isError, visualizationData, visualizationType, visualizationMetaData]

Check warning on line 319 in public/components/custom_panels/panel_modules/visualization_container/visualization_container.tsx

View workflow job for this annotation

GitHub Actions / Lint 

React Hook useMemo has a missing dependency: 'showModal'. Either include it or remove the dependency array
);

useEffect(() => {
loadVisaulization();
}, [onRefresh, inputMetaData, span, resolution, fromTime, toTime]);

Check warning on line 324 in public/components/custom_panels/panel_modules/visualization_container/visualization_container.tsx

View workflow job for this annotation

GitHub Actions / Lint 

React Hook useEffect has a missing dependency: 'loadVisaulization'. Either include it or remove the dependency array

const metricVisCssClassName = catalogVisualization ? 'metricVis' : '';

Expand Down
Loading