Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade plotly to v2 #1432

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

joshuali925
Copy link
Member

@joshuali925 joshuali925 commented Feb 12, 2024

Description

fixes CVE-2023-46308

i tested trace analytics and did some basic sanity tests and didn't see issues, but need owners to double check functionality and any breaking changes for the plotly major version upgrade https://github.com/plotly/plotly.js/releases/tag/v2.0.0

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joshua Li <joshuali925@gmail.com>
@mengweieric mengweieric added the Mend: dependency security vulnerability Security vulnerability detected by Mend label Feb 19, 2024
@joshuali925 joshuali925 merged commit 9750c82 into opensearch-project:main Feb 19, 2024
12 of 25 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1432-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9750c82fce1387297b337a724a523c2c9b4dd59c
# Push it to GitHub
git push --set-upstream origin backport/backport-1432-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1432-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-1.3
# Create a new branch
git switch --create backport/backport-1432-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9750c82fce1387297b337a724a523c2c9b4dd59c
# Push it to GitHub
git push --set-upstream origin backport/backport-1432-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-1432-to-1.3.

joshuali925 added a commit to joshuali925/dashboards-observability that referenced this pull request Feb 19, 2024
Signed-off-by: Joshua Li <joshuali925@gmail.com>
(cherry picked from commit 9750c82)
joshuali925 added a commit to joshuali925/dashboards-observability that referenced this pull request Feb 19, 2024
Signed-off-by: Joshua Li <joshuali925@gmail.com>
(cherry picked from commit 9750c82)
joshuali925 added a commit to joshuali925/dashboards-observability that referenced this pull request Feb 19, 2024
Signed-off-by: Joshua Li <joshuali925@gmail.com>
(cherry picked from commit 9750c82)
(cherry picked from commit 24d4b78)
joshuali925 added a commit that referenced this pull request Feb 19, 2024
Signed-off-by: Joshua Li <joshuali925@gmail.com>
(cherry picked from commit 9750c82)
(cherry picked from commit 24d4b78)
joshuali925 added a commit that referenced this pull request Feb 19, 2024
Signed-off-by: Joshua Li <joshuali925@gmail.com>
(cherry picked from commit 9750c82)
joshuali925 added a commit that referenced this pull request Feb 19, 2024
Signed-off-by: Joshua Li <joshuali925@gmail.com>
(cherry picked from commit 9750c82)
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
Signed-off-by: Joshua Li <joshuali925@gmail.com>
(cherry picked from commit 9750c82)
(cherry picked from commit 4c45cc5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants