[Explorer] Data selector enhancement and refactoring adoptions #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
mengweieric
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
Swiddis
approved these changes
Apr 30, 2024
YANG-DB
reviewed
Apr 30, 2024
| @@ -6,25 +6,26 @@ | |||
| import { DataSource } from '../../../../../src/plugins/data/public'; | |||
|
|
|||
| interface DataSourceConfig { | |||
| id: string; | |||
There was a problem hiding this comment.
can we add a list of labels (string array) for future filtering and association support ?
joshuali925
approved these changes
Apr 30, 2024
|
It looks like all of the integration test actions are failing, including the ones that weren't failing before -- Can you investigate? |
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
paulstn
approved these changes
Apr 30, 2024
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
* support new changes in data selector Signed-off-by: Eric <menwe@amazon.com> * add a missing dependency Signed-off-by: Eric <menwe@amazon.com> * changes addressing reviews Signed-off-by: Eric <menwe@amazon.com> * fix delete s3 data source issue Signed-off-by: Eric <menwe@amazon.com> * error handling Signed-off-by: Eric <menwe@amazon.com> * code clean up Signed-off-by: Eric <menwe@amazon.com> --------- Signed-off-by: Eric <menwe@amazon.com> (cherry picked from commit 552d720) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric
pushed a commit
that referenced
this pull request
Apr 30, 2024
#1771) * support new changes in data selector * add a missing dependency * changes addressing reviews * fix delete s3 data source issue * error handling * code clean up --------- (cherry picked from commit 552d720) Signed-off-by: Eric <menwe@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Data selector in core has a set of enhancements and refactoring which require the same counterpart in explorer to also change accordingly.
https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6571]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.