Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated java version from 11 to 21 #1940

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

sumukhswamy
Copy link
Collaborator

@sumukhswamy sumukhswamy commented Jul 16, 2024

Description

changed github workflow for java version from 11 to 21

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
@derek-ho
Copy link
Collaborator

We shouldn't backport this since 21 is not going to 2.x

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a main issue for bumping java 11 to 21?

@RyanL1997
Copy link
Collaborator

@joshuali925 I think it is referencing to the sql backend version bump: opensearch-project/sql#2787

@sumukhswamy sumukhswamy merged commit 7566cff into opensearch-project:main Jul 17, 2024
13 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants