update s3 regex

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
opensearch-project · Oct 25, 2023 · 984defc · 984defc
1 parent a6fac65
commit 984defc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/common/constants/index.ts b/common/constants/index.ts
@@ -72,7 +72,7 @@ export const SKIPPING_INDEX_ACCELERATION_METHODS = [
 
 export const ACCELERATION_ADD_FIELDS_TEXT = '(add fields here)';
 export const ACCELERATION_INDEX_NAME_REGEX = /^[a-z][a-z_]*$/;
-export const ACCELERATION_S3_URL_REGEX = /^(s3|s3a):\/\/[a-zA-Z0-9.\-]+\/.*/;
+export const ACCELERATION_S3_URL_REGEX = /^(s3|s3a):\/\/[a-zA-Z0-9.\-]+/;
 export const ACCELERATION_DEFUALT_SKIPPING_INDEX_NAME = 'skipping';
 
 export const ACCELERATION_INDEX_NAME_INFO = `All OpenSearch acceleration indices have a naming format of pattern: \`prefix_<index name>_suffix\`. They share a common prefix structure, which is \`flint_<data source name>_<database name>_<table name>_\`. Additionally, they may have a suffix that varies based on the index type. 

diff --git a/public/components/acceleration/create/__tests__/utils.test.tsx b/public/components/acceleration/create/__tests__/utils.test.tsx
@@ -186,6 +186,11 @@ describe('validateCheckpointLocation', () => {
     expect(validCheckpoint).toEqual([]);
   });
 
+  it('should return an empty array when the checkpoint location is a valid S3A URL with just bucket in checkpoint', () => {
+    const validCheckpoint = validateCheckpointLocation('auto', 's3a://valid-s3-bucket');
+    expect(validCheckpoint).toEqual([]);
+  });
+
   it('should return an empty array when using manual refresh with no checkpoint location', () => {
     const validMaterializedCheckpoint = validateCheckpointLocation('manual', '');
     expect(validMaterializedCheckpoint).toEqual([]);