Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed spinner when datasource is opensearch #144

Closed
wants to merge 1 commit into from
Closed

fixed spinner when datasource is opensearch #144

wants to merge 1 commit into from

Conversation

sumukhswamy
Copy link
Collaborator

Description

fixed spinner when Opensearch datasource

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #144 (8501a4c) into main (9a5a20f) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   54.90%   54.97%   +0.07%     
==========================================
  Files          33       33              
  Lines        1346     1346              
  Branches      207      208       +1     
==========================================
+ Hits          739      740       +1     
+ Misses        529      528       -1     
  Partials       78       78              
Flag Coverage Δ
dashboards-query-workbench 54.97% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link
Collaborator

@kavithacm kavithacm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix merge conflicts ?

@ps48
Copy link
Member

ps48 commented Oct 5, 2023

merged here: #140

@ps48 ps48 closed this Oct 5, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants