Add materlized views, manual refresh option and minor fixes #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
ps48
requested review from
pjfitzgibbons,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand and
anirudha
as code owners
Codecov Report
@@ Coverage Diff @@
## main #159 +/- ##
==========================================
- Coverage 54.72% 54.51% -0.22%
==========================================
Files 33 33
Lines 1365 1385 +20
Branches 216 220 +4
==========================================
+ Hits 747 755 +8
- Misses 537 546 +9
- Partials 81 84 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
derek-ho
reviewed
Oct 18, 2023
| @@ -37,6 +37,8 @@ interface SQLPageProps { | |||
| sqlTranslations: ResponseDetail<TranslateResult>[]; | |||
| selectedDatasource: EuiComboBoxOptionOption[]; | |||
| asyncLoading: boolean; | |||
| openAccelerationFlyout: boolean; | |||
There was a problem hiding this comment.
Can we change this to something like isAccelerationFlyoutOpen
There was a problem hiding this comment.
isAccelerationFlyoutOpen doesn't make much sense as a name here. This prop dictates should be acceleration flyout be opened or not by the SQL page component.
ex:
if parent props sends value openAccelerationFlyout={true} -> the child component opens the flyout
derek-ho
reviewed
Oct 18, 2023
Comment on lines
+830
to
+831
| openAccelerationFlyout={ | ||
| this.props.isAccelerationFlyoutOpen && !this.state.isAccelerationFlyoutOpened |
There was a problem hiding this comment.
I don't quite get why these two booleans are used?
There was a problem hiding this comment.
One is for the prop which dictates if URL has a datasource that needs to be open with acceleration flyout. The other is to keep a local state. We need the local state to make sure, the URL flyout only opens once.
kavithacm
approved these changes
Oct 18, 2023
YANG-DB
approved these changes
Oct 18, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
* enable materialized views, update acc btn fill Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update acceleration links Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add manual refresh option, update tests Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update copy for datasources Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * fix redirection issue Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 43b085b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Oct 18, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
* enable materialized views, update acc btn fill Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update acceleration links Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add manual refresh option, update tests Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update copy for datasources Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * fix redirection issue Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 43b085b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Oct 18, 2023
) * enable materialized views, update acc btn fill * update acceleration links * add manual refresh option, update tests * update copy for datasources * fix redirection issue --------- (cherry picked from commit 43b085b) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Oct 18, 2023
) * enable materialized views, update acc btn fill * update acceleration links * add manual refresh option, update tests * update copy for datasources * fix redirection issue --------- (cherry picked from commit 43b085b) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric
added a commit
to mengweieric/dashboards-query-workbench
that referenced
this pull request
Nov 13, 2023
…pensearch-project#159) (opensearch-project#161)" This reverts commit 88970fb. Signed-off-by: Eric <menwe@amazon.com>
6 tasks
mengweieric
added a commit
that referenced
this pull request
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
#127
Depends on opensearch-project/opensearch-spark#73
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.