[Backport 2.x] Added changes for making tree view persistent, made changes for bugs for loading screen #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…for loading screen (#153) * made the tree persistant, added changes for loading screen Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * changes for the text displayed during loading screen Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * addressed pr comments, added code for reload button Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * addressed pr comments, added Materialiazed view badges, bug fixes for loading state Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated snapshots Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added tests, addressed pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added fix for text overflowing Signed-off-by: sumukhswamy <sumukhhs@amazon.com> --------- Signed-off-by: sumukhswamy <sumukhhs@amazon.com> (cherry picked from commit 75f9cca) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand and
anirudha
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #166 +/- ##
==========================================
+ Coverage 54.79% 59.02% +4.22%
==========================================
Files 33 33
Lines 1356 1452 +96
Branches 210 237 +27
==========================================
+ Hits 743 857 +114
- Misses 535 575 +40
+ Partials 78 20 -58
Flags with carried forward coverage won't be shown. Click here to find out more. |
ps48
approved these changes
Oct 20, 2023
kavithacm
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 75f9cca from #153.