Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Support dark mode and session for sql, minor bug fixes #168

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 937ff30 from #165.

* suport dark mode and editor theming from dev tools

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* remove sql editor theme, add session check

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update snapshots

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* minor fixes

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* fix import

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* fix job query url

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update poll interval to 2000

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit 937ff30)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #168 (f88003f) into 2.x (3e45ef7) will increase coverage by 3.88%.
Report is 6 commits behind head on 2.x.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              2.x     #168      +/-   ##
==========================================
+ Coverage   54.79%   58.68%   +3.88%     
==========================================
  Files          33       32       -1     
  Lines        1356     1428      +72     
  Branches      210      234      +24     
==========================================
+ Hits          743      838      +95     
- Misses        535      570      +35     
+ Partials       78       20      -58     
Flag Coverage Δ
dashboards-query-workbench 58.68% <ø> (+3.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 19 files with indirect coverage changes

@ps48 ps48 merged commit 6f5944d into 2.x Oct 23, 2023
8 checks passed
@github-actions github-actions bot deleted the backport/backport-165-to-2.x branch October 23, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant