[Backport 2.x] Make checkpoint mandatory, add watermark delay, minor UI fixes #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* make checkpoint mandatory Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update timestamp type for MV Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add watermark and datasource empty check Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * minor fixes Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * updates datasources acc Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * adding tests for watermark, minor fixes Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update acc index flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update docs links Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit a5aa2d2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand and
anirudha
as code owners
ps48
approved these changes
Oct 24, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #174 +/- ##
==========================================
+ Coverage 54.79% 58.39% +3.60%
==========================================
Files 33 32 -1
Lines 1356 1507 +151
Branches 210 260 +50
==========================================
+ Hits 743 880 +137
- Misses 535 605 +70
+ Partials 78 22 -56
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport a5aa2d2 from #173.