Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Moving Query Workbench to Dev Tools (#349) #356

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Jul 19, 2024

  • Migrate to devTools

Signed-off-by: Adam Tackett tackadam@amazon.com

  • MDS working changed how ID passed

Signed-off-by: Adam Tackett tackadam@amazon.com

  • Chagned name to dataSourceMDSId

Signed-off-by: Adam Tackett tackadam@amazon.com

  • remove console log

Signed-off-by: Adam Tackett tackadam@amazon.com

  • add support for backward URLs

Signed-off-by: Shenoy Pratik sgguruda@amazon.com

  • update nav coditionally and set breadcrumbs

Signed-off-by: Shenoy Pratik sgguruda@amazon.com

  • fix lint error

Signed-off-by: Shenoy Pratik sgguruda@amazon.com

  • update breadcrumb only when nav is enabled

Signed-off-by: Shenoy Pratik sgguruda@amazon.com

  • fix URL for new nav is disabled

Signed-off-by: Shenoy Pratik sgguruda@amazon.com


Signed-off-by: Adam Tackett tackadam@amazon.com
Signed-off-by: Shenoy Pratik sgguruda@amazon.com
Co-authored-by: Adam Tackett tackadam@amazon.com
Co-authored-by: Shenoy Pratik sgguruda@amazon.com
(cherry picked from commit 7aba1fd)

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Migrate to devTools

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* MDS working changed how ID passed

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* Chagned name to dataSourceMDSId

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* remove console log

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* add support for backward URLs

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update nav coditionally and set breadcrumbs

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* fix lint error

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update breadcrumb only when nav is enabled

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* fix URL for new nav is disabled

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Co-authored-by: Adam Tackett <tackadam@amazon.com>
Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit 7aba1fd)
@ps48 ps48 merged commit e578ec4 into opensearch-project:2.x Jul 19, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants