Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI. #82

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Update CI. #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions .github/workflows/sql-workbench-test-build-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,6 @@ on:
push:
branches-ignore:
- 'dependabot/**'
paths:
- '.'
- '.github/workflows/sql-workbench-test-build-workflow.yml'

env:
PLUGIN_NAME: dashboards-query-workbench
OPENSEARCH_VERSION: 'main'
OPENSEARCH_PLUGIN_VERSION: 2.4.0.0

jobs:
tests:
Expand All @@ -27,10 +19,9 @@ jobs:
if: ${{ matrix.os == 'windows-latest' }}
run: git config --system core.longpaths true
- name: Checkout OpenSearch Dashboards
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
repository: opensearch-project/OpenSearch-Dashboards
ref: ${{ env.OPENSEARCH_DASHBOARDS_VERSION }}
path: OpenSearch-Dashboards
- name: Setup Node
uses: actions/setup-node@v3
Expand All @@ -47,7 +38,7 @@ jobs:
- run: node -v
- run: yarn -v
- name: Checkout workbench OpenSearch Dashboards plugin
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
path: OpenSearch-Dashboards/plugins/dashboards-query-workbench
- name: Bootstrap plugin/opensearch-dashboards
Expand All @@ -66,13 +57,14 @@ jobs:
directory: OpenSearch-Dashboards/plugins/dashboards-query-workbench
token: ${{ secrets.CODECOV_TOKEN }}
- name: Build Artifact
if: always()
run: |
cd OpenSearch-Dashboards/plugins/dashboards-query-workbench
yarn build
mv ./build/*.zip ./build/${{ env.PLUGIN_NAME }}-${{ env.OPENSEARCH_PLUGIN_VERSION }}.zip
mv ./build/*.zip ./build/dashboards-query-workbench.zip
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come version was removed from the filename?

Copy link
Collaborator Author

@Yury-Fridlyand Yury-Fridlyand Jun 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a hardcoded fixed and already outdated value which comes to the file name inside the CI artifact.

- name: Upload Artifact
if: always()
uses: actions/upload-artifact@v1 # can't update to v3 because upload fails
uses: actions/upload-artifact@v3
with:
name: dashboards-query-workbench-${{ matrix.os }}
path: OpenSearch-Dashboards/plugins/dashboards-query-workbench/build
Loading