Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add id attribute to search bar #338

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

nung22
Copy link
Contributor

@nung22 nung22 commented Oct 24, 2023

Description

Noticed that OuiFieldSearch was raising the suggested improvement: "A form field element should have an id or name attribute". Added the id "searchRelevance-searchBar" to the component, which resolves the issue. Also fixes a unique key error that was being generated by the getDlTmpl component of ResultGridComponent.

Issues Resolved

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Screenshots

Screenshot 2023-10-24 092353

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #338 (e2a992c) into main (9e7923a) will increase coverage by 3.62%.
The diff coverage is n/a.

❗ Current head e2a992c differs from pull request most recent head 0d821cb. Consider uploading reports for the commit 0d821cb to get more accurate results

@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
+ Coverage   83.46%   87.08%   +3.62%     
==========================================
  Files          32       16      -16     
  Lines         393      209     -184     
  Branches       77       43      -34     
==========================================
- Hits          328      182     -146     
+ Misses         45       26      -19     
+ Partials       20        1      -19     
Flag Coverage Δ
dashboards-search-relevance 87.08% <ø> (+3.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...re/search_result/result_components/result_grid.tsx 90.90% <ø> (+6.29%) ⬆️
...are/search_result/search_components/search_bar.tsx 75.00% <ø> (+8.33%) ⬆️

... and 23 files with indirect coverage changes

@sejli sejli merged commit c64b9f5 into opensearch-project:main Nov 29, 2023
5 of 10 checks passed
github-actions bot added a commit that referenced this pull request Nov 29, 2023
* Add id to search bar

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Add keys to getDlTmpl component

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Change enclosing tag to span instead of div

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

---------

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
(cherry picked from commit c64b9f5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sejli pushed a commit that referenced this pull request Nov 29, 2023
* Add id to search bar



* Add keys to getDlTmpl component



* Change enclosing tag to span instead of div



---------


(cherry picked from commit c64b9f5)

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
nung22 added a commit to nung22/dashboards-search-relevance that referenced this pull request Nov 29, 2023
* Add id to search bar

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Add keys to getDlTmpl component

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Change enclosing tag to span instead of div

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

---------

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
@nung22 nung22 deleted the fix/add-searchbar-id branch December 31, 2023 04:06
sejli pushed a commit that referenced this pull request Jan 26, 2024
…352)

* Add search pipeline parameters to index and route files

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Add search pipeline dropdown

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Integrate option to select search pipeline

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Update tests and snapshots

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Update get pipelines endpoint

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Update .babelrc

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Update test snapshots

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Add id attribute to search bar (#338)

* Add id to search bar

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Add keys to getDlTmpl component

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Change enclosing tag to span instead of div

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

---------

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Update .babelrc

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Add ability to select _none option

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Update test coverages

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Update variables in pipeline selection

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

---------

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
github-actions bot added a commit that referenced this pull request Jan 26, 2024
…352)

* Add search pipeline parameters to index and route files

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Add search pipeline dropdown

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Integrate option to select search pipeline

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Update tests and snapshots

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Update get pipelines endpoint

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Update .babelrc

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Update test snapshots

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Add id attribute to search bar (#338)

* Add id to search bar

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Add keys to getDlTmpl component

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Change enclosing tag to span instead of div

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

---------

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Update .babelrc

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Add ability to select _none option

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Update test coverages

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

* Update variables in pipeline selection

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

---------

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
(cherry picked from commit 29e5867)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sejli pushed a commit that referenced this pull request Jan 26, 2024
…352) (#362)

* Add search pipeline parameters to index and route files



* Add search pipeline dropdown



* Integrate option to select search pipeline



* Update tests and snapshots



* Update get pipelines endpoint



* Update .babelrc



* Update test snapshots



* Add id attribute to search bar (#338)

* Add id to search bar



* Add keys to getDlTmpl component



* Change enclosing tag to span instead of div



---------



* Update .babelrc



* Add ability to select _none option



* Update test coverages



* Update variables in pipeline selection



---------


(cherry picked from commit 29e5867)

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants