Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Jest snapshot for 2.12 Release #363

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

sejli
Copy link
Member

@sejli sejli commented Feb 6, 2024

Description

Updates Jest snapshots using yarn test -u to fix build. This change to OUI set Beaker to the default icon type, which requires an update to our snapshots.

Issues Resolved

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sean Li <lnse@amazon.com>
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (c2f175b) 83.54% compared to head (c64657d) 83.13%.
Report is 1 commits behind head on main.

Files Patch % Lines
...search_components/search_configs/search_config.tsx 50.00% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   83.54%   83.13%   -0.42%     
==========================================
  Files          32       32              
  Lines         395      415      +20     
  Branches       77       81       +4     
==========================================
+ Hits          330      345      +15     
- Misses         45       49       +4     
- Partials       20       21       +1     
Flag Coverage Δ
dashboards-search-relevance 83.13% <61.53%> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sejli sejli changed the title Updating Jest snapshot Updating Jest snapshot for 2.12 Release Feb 6, 2024
@sejli sejli merged commit caee2ba into opensearch-project:main Feb 6, 2024
11 of 12 checks passed
github-actions bot added a commit that referenced this pull request Feb 6, 2024
Signed-off-by: Sean Li <lnse@amazon.com>
(cherry picked from commit caee2ba)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sejli pushed a commit that referenced this pull request Feb 6, 2024
(cherry picked from commit caee2ba)

Signed-off-by: Sean Li <lnse@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants