Navigate to Import Sample Data Page without Refresh when New Home is Enabled #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <wonglam@amazon.com>
wanglam
requested review from
macohen,
mingshl,
msfroh,
noCharger,
sejli and
sumukhswamy
as code owners
ruanyl
approved these changes
Oct 21, 2024
sejli
approved these changes
Oct 21, 2024
|
Hi @sejli , Yes. I think this changes should be backport to 2.x branch. Feel free to help me add the label, thank you. |
github-actions bot
added a commit
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Lin Wang <wonglam@amazon.com> (cherry picked from commit d01d2ff) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sejli
pushed a commit
that referenced
this pull request
Oct 21, 2024
(cherry picked from commit d01d2ff) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue of navigating to the import sample data page without causing a page refresh when the new home page and workspace are enabled.
Changes:
CreateIndexcomponent to check if the new home page and workspace are enabled.onClickhandler to the "Add Sample Data" link when the new home page and workspace are enabled.onClickhandler, calledapplication.navigateToAppwithimport_sample_datato navigate to the import sample data page without causing a page refresh.Issues Resolved
#456
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.