Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce sleep times in BlockingBufferTests to speed up unit tests. #3221

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Reduce sleep times in BlockingBufferTests to speed up unit tests. #3221

merged 1 commit into from
Aug 29, 2023

Conversation

dlvenable
Copy link
Member

Description

The BlockingBufferTests use read timeouts of 5 seconds. This reduces them to 0.5 seconds. The Gradle test task is now running at 5 seconds rather than 40 seconds.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dlvenable
Reduce sleep times in BlockingBufferTests to speed up unit tests.
b52c032 
Signed-off-by: David Venable <dlv@amazon.com>
@dlvenable dlvenable merged commit e845966 into opensearch-project:main Aug 29, 2023
24 checks passed
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 29, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 29, 2023
@dlvenable @github-actions
Reduce sleep times in BlockingBufferTests to speed up unit tests. (#3221
b2380bc 
)

Signed-off-by: David Venable <dlv@amazon.com>
(cherry picked from commit e845966)
dlvenable added a commit that referenced this pull request Sep 1, 2023
@opensearch-trigger-bot @dlvenable
Reduce sleep times in BlockingBufferTests to speed up unit tests. (#3221
d672ec9 
) (#3287)

Signed-off-by: David Venable <dlv@amazon.com>
(cherry picked from commit e845966)

Co-authored-by: David Venable <dlv@amazon.com>
@dlvenable dlvenable deleted the buffer-tests-speed-up branch November 10, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenqi0805 chenqi0805 chenqi0805 approved these changes

@asifsmohammed asifsmohammed asifsmohammed approved these changes

@engechas engechas Awaiting requested review from engechas engechas is a code owner

@graytaylor0 graytaylor0 Awaiting requested review from graytaylor0 graytaylor0 is a code owner

@dinujoh dinujoh Awaiting requested review from dinujoh dinujoh is a code owner

@kkondaka kkondaka Awaiting requested review from kkondaka kkondaka is a code owner

@oeyh oeyh Awaiting requested review from oeyh oeyh is a code owner

Assignees
No one assigned
Labels
backport 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlvenable @asifsmohammed @chenqi0805