Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes Maxmind license keys from test URLs #3270

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Removes Maxmind license keys from test URLs #3270

merged 1 commit into from
Aug 28, 2023

Conversation

dlvenable
Copy link
Member

Description

Removes Maxmind license keys which should not be present in code.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dlvenable
Removes Maxmind license keys from test URLs.
64b8812 
Signed-off-by: David Venable <dlv@amazon.com>
JonahCalvo
JonahCalvo approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@JonahCalvo JonahCalvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this David <3

@dlvenable dlvenable merged commit f70ee73 into opensearch-project:main Aug 28, 2023
22 of 24 checks passed
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 29, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 29, 2023
@dlvenable @github-actions
Removes Maxmind license keys from test URLs. (#3270)
97a8d27 
Signed-off-by: David Venable <dlv@amazon.com>
(cherry picked from commit f70ee73)
dlvenable added a commit that referenced this pull request Aug 29, 2023
@opensearch-trigger-bot @dlvenable
Removes Maxmind license keys from test URLs. (#3270) (#3285)
93818e8 
Signed-off-by: David Venable <dlv@amazon.com>
(cherry picked from commit f70ee73)

Co-authored-by: David Venable <dlv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonahCalvo JonahCalvo JonahCalvo approved these changes

@oeyh oeyh oeyh approved these changes

@chenqi0805 chenqi0805 Awaiting requested review from chenqi0805 chenqi0805 is a code owner

@engechas engechas Awaiting requested review from engechas engechas is a code owner

@graytaylor0 graytaylor0 Awaiting requested review from graytaylor0 graytaylor0 is a code owner

@dinujoh dinujoh Awaiting requested review from dinujoh dinujoh is a code owner

@kkondaka kkondaka Awaiting requested review from kkondaka kkondaka is a code owner

@asifsmohammed asifsmohammed Awaiting requested review from asifsmohammed

Assignees
No one assigned
Labels
backport 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlvenable @oeyh @JonahCalvo