Use async client to delete scroll and pit for OpenSearch as workaroun… #3338
Conversation
…d for bug in client Signed-off-by: Taylor Gray <tylgry@amazon.com>
graytaylor0
requested review from
chenqi0805,
engechas,
dinujoh,
kkondaka,
asifsmohammed,
dlvenable and
oeyh
as code owners
| @@ -126,7 +130,7 @@ public SearchWithSearchAfterResults searchWithPit(final SearchPointInTimeRequest | |||
| @Override | |||
| public void deletePit(final DeletePointInTimeRequest deletePointInTimeRequest) { | |||
| try { | |||
| final DeletePitResponse deletePitResponse = openSearchClient.deletePit(DeletePitRequest.of(builder -> builder.pitId(Collections.singletonList(deletePointInTimeRequest.getPitId())))); | |||
| final DeletePitResponse deletePitResponse = openSearchAsyncClient.deletePit(DeletePitRequest.of(builder -> builder.pitId(Collections.singletonList(deletePointInTimeRequest.getPitId())))); | |||
There was a problem hiding this comment.
So this is still using the existing synchronous method, but the implementation is the "async" client. Right? Why not use only the async client (but in the synchronous way)?
|
Also, this comment indicates that the problem may be the Apache HTTP client. Can we skip using the async client and just change to use Netty underneath? |
The only netty client is the NettyNioAsyncHttpClient. Are you suggesting using this one? |
Yes. As I'm reading this, we have two clients - sync and async. We use them both for synchronous APIs. So why not just change the existing sync client to use |
Signed-off-by: Taylor Gray <tylgry@amazon.com>
Me as well! Good call |
opensearch-project#3338) Use async client to delete scroll and pit for OpenSearch as workaround for bug in client Signed-off-by: Taylor Gray <tylgry@amazon.com>
…d for bug in client
Description
The OpenSearch Java Client has an issue where delete requests with sigv4 are not signed correctly (opensearch-project/opensearch-java#521).
As a workaround, this change constructs an async OpenSearch client to make only the delete calls for scroll and pit
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.