Fix e2e acks test #3471
Merged
Fix e2e acks test #3471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kondaka <krishkdk@amazon.com>
kkondaka
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
asifsmohammed,
dlvenable and
oeyh
as code owners
dlvenable
requested changes
Oct 10, 2023
Signed-off-by: Kondaka <krishkdk@amazon.com>
|
@dlvenable created the issue #3472 and put milestone as v2.6 |
dlvenable
previously approved these changes
Oct 10, 2023
Signed-off-by: Kondaka <krishkdk@amazon.com>
Signed-off-by: Kondaka <krishkdk@amazon.com>
Signed-off-by: Kondaka <krishkdk@amazon.com>
Signed-off-by: Kondaka <krishkdk@amazon.com>
Signed-off-by: Kondaka <krishkdk@amazon.com>
dlvenable
requested changes
Oct 11, 2023
| @@ -44,13 +45,15 @@ void setUp(String configFile) { | |||
| .withPipelinesDirectoryOrFile(configFile) | |||
| .build(); | |||
|
|
|||
| System.out.println("Data Prepper Test with config file "+ configFile + " started at "+Instant.now()); | |||
There was a problem hiding this comment.
Please change this to an SLF4J log line.
LOG.info("PipelinesWithAcksIT with configu file {} started at {}", configFile, Instant.now());
| dataPrepperTestRunner.start(); | ||
| inMemorySourceAccessor = dataPrepperTestRunner.getInMemorySourceAccessor(); | ||
| inMemorySinkAccessor = dataPrepperTestRunner.getInMemorySinkAccessor(); | ||
| } | ||
|
|
||
| @AfterEach | ||
| void tearDown() { | ||
| System.out.println("Data Prepper Test stopped at "+Instant.now()); |
| @@ -115,7 +115,7 @@ public void run() { | |||
| try { | |||
| final List<Record<Event>> records = inMemorySourceAccessor.read(testingKey); | |||
| if (records.size() == 0) { | |||
| Thread.sleep(1000); | |||
| Thread.sleep(50); | |||
|
Just a callout I created this issue earlier for flaky tests (#3481). If you fixed one of the ones mentioned in that issue please check it off the list in the issue |
Signed-off-by: Kondaka <krishkdk@amazon.com>
graytaylor0
approved these changes
Oct 11, 2023
dlvenable
approved these changes
Oct 11, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Disable flaky e2e acks test Signed-off-by: Kondaka <krishkdk@amazon.com> * Disabled another flaky test Signed-off-by: Kondaka <krishkdk@amazon.com> * Added debug statements to debug the failing tests Signed-off-by: Kondaka <krishkdk@amazon.com> * Modified to assign unique names to pipelines Signed-off-by: Kondaka <krishkdk@amazon.com> * Trying with enabling the disabled test Signed-off-by: Kondaka <krishkdk@amazon.com> * Fixed failing checkstyle error Signed-off-by: Kondaka <krishkdk@amazon.com> * Reduced sleep time in InMemorySource Signed-off-by: Kondaka <krishkdk@amazon.com> * Modified to use log4j Signed-off-by: Kondaka <krishkdk@amazon.com> --------- Signed-off-by: Kondaka <krishkdk@amazon.com> (cherry picked from commit 400b2a8)
dlvenable
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Disable flaky e2e acks test Signed-off-by: Kondaka <krishkdk@amazon.com> * Disabled another flaky test Signed-off-by: Kondaka <krishkdk@amazon.com> * Added debug statements to debug the failing tests Signed-off-by: Kondaka <krishkdk@amazon.com> * Modified to assign unique names to pipelines Signed-off-by: Kondaka <krishkdk@amazon.com> * Trying with enabling the disabled test Signed-off-by: Kondaka <krishkdk@amazon.com> * Fixed failing checkstyle error Signed-off-by: Kondaka <krishkdk@amazon.com> * Reduced sleep time in InMemorySource Signed-off-by: Kondaka <krishkdk@amazon.com> * Modified to use log4j Signed-off-by: Kondaka <krishkdk@amazon.com> --------- Signed-off-by: Kondaka <krishkdk@amazon.com> (cherry picked from commit 400b2a8) Co-authored-by: kkondaka <41027584+kkondaka@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix flaky test in e2e acks integration test.
Modified the sleep time in InMemorySource to 50ms
Resolves #3481
Issues Resolved
Resolves #3481
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.