Support plugins defining the EventKey in plugin configurations #4635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sses. Data Prepper will deserialize the EventKey from the pipeline configuration and validate @notempty validations. Builds on the opensearch-project#1916. Signed-off-by: David Venable <dlv@amazon.com>
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed,
KarstenSchnitter and
oeyh
as code owners
4 tasks
|
See #4636 for how we can use this in some processors. Also, the integration tests I added show how to use it. |
graytaylor0
approved these changes
Jun 18, 2024
kkondaka
approved these changes
Jun 19, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Data Prepper core can now parse
EventKeyobjects for plugin configurations. Additionally, validation using@NotEmptyalso works.Specific changes:
EventKey@NotEmptyannotation withEventKey.EventKeyConfigurationannotation that allows plugin authors to configure how they will use theEventKey.Issues Resolved
N/A, but this enhances the work done for #1916.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.