Fix null pointer exception during exception evaluation #5217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>
dlvenable
requested changes
Dec 2, 2024
| @@ -102,7 +102,6 @@ public Collection<Record<Event>> doExecute(final Collection<Record<Event>> recor | |||
| .addArgument(entry.getValueExpression()) | |||
| .addArgument(entry.getFormat()) | |||
| .addArgument(entry.getValue()) | |||
| .setCause(e) | |||
There was a problem hiding this comment.
We should include the cause whenever we catch Exception. Please add a new catch for the known exception(s) when these errors arise.
e.g.
catch (InvalidExpressionException e) {
// log without exception
} catch (Exception e) {
// log with the exception
}
| try { | ||
| result = evaluate(statement, context); | ||
| if (result == null) { | ||
| return false; |
There was a problem hiding this comment.
I'm not sure that this is correct. This indicates a bug with our exception handling because any boolean expression should return non-null. Maybe we need to handle this by throwing a more specific exception. Or perhaps we log this case.
| @@ -37,7 +37,7 @@ public Object evaluate(ParseTree parseTree, Event event) { | |||
| walker.walk(listener, parseTree); | |||
| return listener.getResult(); | |||
| } catch (final Exception e) { | |||
| LOG.error("Unable to evaluate event", e); | |||
| LOG.error(e.getMessage()); | |||
There was a problem hiding this comment.
We should log the stack trace when catching Exception.
Please add new catch statements for known exceptions (e.g. parse error) and log those without the stack trace.
| @@ -119,7 +118,7 @@ void testGenericExpressionEvaluatorWithMultipleThreads(final String expression, | |||
| void testGenericExpressionEvaluatorThrows(final String expression, final Event event) { | |||
| final GenericExpressionEvaluator evaluator = applicationContext.getBean(GenericExpressionEvaluator.class); | |||
|
|
|||
| assertThrows(RuntimeException.class, () -> evaluator.evaluateConditional(expression, event)); | |||
| assertThat(evaluator.evaluateConditional(expression, event), equalTo(false)); | |||
There was a problem hiding this comment.
This behavior does not seem correct.
Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix null pointer exception during exception evaluation.
Modified to check for null objects before evaluating expressions.
Modified to catch exception in conditional expression evaluation and return false instead of throwing the exception
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.