Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe SAML supported private key format and encryption algorithm #1855

Merged
merged 1 commit into from
May 18, 2023

Conversation

agabrys
Copy link
Contributor

@agabrys agabrys commented Nov 11, 2022

Description

OpenSearch allows signing requests by using a private key in the PKCS#8 format. If a user wants to use an encrypted key, the key must be encrypted with a PKCS#12-compatible algorithm.

The SAML -> Request signing documentation is extended with the requirements. It should save time of the customers who use wrong key formats or a good key format, but encrypted with an unsupported algorithm (e.g. PKCS#5 2.0 compatible algorithm).

Issues Resolved

N/A

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ariamarble
Copy link
Contributor

@cwillum can you take a look at this one?

@agabrys agabrys force-pushed the patch-1 branch 2 times, most recently from 2388656 to 37e17b8 Compare March 17, 2023 12:12
@agabrys
Copy link
Contributor Author

agabrys commented Mar 17, 2023

I rebased with the main branch to solve the merge conflict.

@Naarcha-AWS
Copy link
Collaborator

@agabrys: I went ahead and fixed the merge conflict for you.

OpenSearch allows signing requests by using a private key in the PKCS#8 format. If a user wants to use an encrypted key, the key must be encrypted with a PKCS#12-compatible algorithm.

The `SAML -> Request signing` documentation is extended with the requirements. It should save time of the customers who use wrong key formats or a good key format, but encrypted with an unsupported algorithm (e.g. PKCS#5 2.0 compatible algorithm).

Signed-off-by: Adam Gabryś <adam.gabrys@live.com>
@agabrys
Copy link
Contributor Author

agabrys commented Apr 7, 2023

@Naarcha-AWS there was a change which should not be a part of my PR (the The Security plugin supports the following signature algorithms. line) . I rebased it with the main branch one more time 🙂

@Naarcha-AWS Naarcha-AWS added the backport 2.7 PR: Backport label for 2.7 label May 18, 2023
@Naarcha-AWS Naarcha-AWS merged commit b52424e into opensearch-project:main May 18, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 18, 2023
…1855)

OpenSearch allows signing requests by using a private key in the PKCS#8 format. If a user wants to use an encrypted key, the key must be encrypted with a PKCS#12-compatible algorithm.

The `SAML -> Request signing` documentation is extended with the requirements. It should save time of the customers who use wrong key formats or a good key format, but encrypted with an unsupported algorithm (e.g. PKCS#5 2.0 compatible algorithm).

Signed-off-by: Adam Gabryś <adam.gabrys@live.com>
(cherry picked from commit b52424e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Naarcha-AWS pushed a commit that referenced this pull request May 18, 2023
…1855) (#4109)

OpenSearch allows signing requests by using a private key in the PKCS#8 format. If a user wants to use an encrypted key, the key must be encrypted with a PKCS#12-compatible algorithm.

The `SAML -> Request signing` documentation is extended with the requirements. It should save time of the customers who use wrong key formats or a good key format, but encrypted with an unsupported algorithm (e.g. PKCS#5 2.0 compatible algorithm).


(cherry picked from commit b52424e)

Signed-off-by: Adam Gabryś <adam.gabrys@live.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vagimeli pushed a commit that referenced this pull request May 26, 2023
…1855)

OpenSearch allows signing requests by using a private key in the PKCS#8 format. If a user wants to use an encrypted key, the key must be encrypted with a PKCS#12-compatible algorithm.

The `SAML -> Request signing` documentation is extended with the requirements. It should save time of the customers who use wrong key formats or a good key format, but encrypted with an unsupported algorithm (e.g. PKCS#5 2.0 compatible algorithm).

Signed-off-by: Adam Gabryś <adam.gabrys@live.com>
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this pull request Oct 31, 2023
…pensearch-project#1855)

OpenSearch allows signing requests by using a private key in the PKCS#8 format. If a user wants to use an encrypted key, the key must be encrypted with a PKCS#12-compatible algorithm.

The `SAML -> Request signing` documentation is extended with the requirements. It should save time of the customers who use wrong key formats or a good key format, but encrypted with an unsupported algorithm (e.g. PKCS#5 2.0 compatible algorithm).

Signed-off-by: Adam Gabryś <adam.gabrys@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.7 PR: Backport label for 2.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants